Skip to content

Commit

Permalink
Make SchedulerMinHeap flow strict (#16351)
Browse files Browse the repository at this point in the history
@acdlite while browsing Twitter, I saw [an opportunity][1] to do
something more productive than browsing Twitter.

[1]: https://twitter.com/acdlite/status/1160247965908234240

Test plan:

`yarn flow-ci`, `yarn test-prod`, `yarn lint`
  • Loading branch information
dmnd authored and acdlite committed Aug 10, 2019
1 parent e349da1 commit 7a7e792
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions packages/scheduler/src/SchedulerMinHeap.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @flow strict
*/

type Heap = Array<Node>;
Expand Down Expand Up @@ -38,7 +38,8 @@ export function pop(heap: Heap): Node | null {
}
}

function siftUp(heap, node, index) {
function siftUp(heap, node, i) {
let index = i;
while (true) {
const parentIndex = Math.floor((index - 1) / 2);
const parent = heap[parentIndex];
Expand All @@ -54,7 +55,8 @@ function siftUp(heap, node, index) {
}
}

function siftDown(heap, node, index) {
function siftDown(heap, node, i) {
let index = i;
const length = heap.length;
while (index < length) {
const leftIndex = (index + 1) * 2 - 1;
Expand Down

0 comments on commit 7a7e792

Please sign in to comment.