Skip to content

Commit

Permalink
Fix fiber feature flag for ReactDOMProduction-test
Browse files Browse the repository at this point in the history
  • Loading branch information
sophiebits committed Nov 29, 2016
1 parent a98e822 commit 9c28796
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions scripts/fiber/tests-failing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ src/renderers/art/__tests__/ReactART-test.js
* resolves refs before componentDidMount
* resolves refs before componentDidUpdate

src/renderers/dom/__tests__/ReactDOMProduction-test.js
* should throw with an error code in production

src/renderers/dom/shared/__tests__/ReactDOM-test.js
* throws in render() if the mount callback is not a function
* throws in render() if the update callback is not a function
Expand Down
1 change: 0 additions & 1 deletion scripts/fiber/tests-passing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,6 @@ src/renderers/dom/__tests__/ReactDOMProduction-test.js
* should use prod React
* should handle a simple flow
* should call lifecycle methods
* should throw with an error code in production

src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js
* should render strings as children
Expand Down
4 changes: 3 additions & 1 deletion src/renderers/dom/__tests__/ReactDOMProduction-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ describe('ReactDOMProduction', () => {
beforeEach(() => {
__DEV__ = false;
oldProcess = process;
global.process = {env: {NODE_ENV: 'production'}};
global.process = {
env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
};

jest.resetModuleRegistry();
React = require('React');
Expand Down

0 comments on commit 9c28796

Please sign in to comment.