Skip to content

Commit

Permalink
Attempt to fix diff syncing for Meta (#28801)
Browse files Browse the repository at this point in the history
#28796 broke Meta's PR syncing tool, hoping this fixes it

DiffTrain build for [64c8d2d](64c8d2d)
  • Loading branch information
josephsavona committed Apr 9, 2024
1 parent e992aaa commit a85aedc
Show file tree
Hide file tree
Showing 9 changed files with 35 additions and 30 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7f93cb41c8e1352eec158e508bc612025425266d
64c8d2d45d49dbb2f59ea23e5e739eb79e124abc
6 changes: 3 additions & 3 deletions compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "19.0.0-www-classic-e729f4fd";
var ReactVersion = "19.0.0-www-classic-8d3386cf";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -2041,6 +2041,8 @@ if (__DEV__) {

if (config != null) {
if (hasValidRef(config)) {
owner = ReactSharedInternals.owner;

if (!enableRefAsProp) {
// Silently steal the ref from the parent.
ref = config.ref;
Expand All @@ -2049,8 +2051,6 @@ if (__DEV__) {
ref = coerceStringRef(ref, owner, element.type);
}
}

owner = ReactSharedInternals.owner;
}

if (hasValidKey(config)) {
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "19.0.0-www-modern-e655a09b";
var ReactVersion = "19.0.0-www-modern-337e1422";

// ATTENTION
// When adding new symbols to this file,
Expand Down Expand Up @@ -2043,6 +2043,8 @@ if (__DEV__) {

if (config != null) {
if (hasValidRef(config)) {
owner = ReactSharedInternals.owner;

if (!enableRefAsProp) {
// Silently steal the ref from the parent.
ref = config.ref;
Expand All @@ -2051,8 +2053,6 @@ if (__DEV__) {
ref = coerceStringRef(ref, owner, element.type);
}
}

owner = ReactSharedInternals.owner;
}

if (hasValidKey(config)) {
Expand Down
9 changes: 5 additions & 4 deletions compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,10 @@ exports.cloneElement = function (element, config, children) {
owner = element._owner;
if (null != config) {
void 0 !== config.ref &&
(enableRefAsProp ||
((ref = config.ref), (ref = coerceStringRef(ref, owner, element.type))),
(owner = ReactSharedInternals.owner));
((owner = ReactSharedInternals.owner),
enableRefAsProp ||
((ref = config.ref),
(ref = coerceStringRef(ref, owner, element.type))));
void 0 !== config.key && (key = "" + config.key);
if (
!disableDefaultPropsExceptForClasses &&
Expand Down Expand Up @@ -690,4 +691,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-4b82ed06";
exports.version = "19.0.0-www-classic-0eabe82a";
9 changes: 5 additions & 4 deletions compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,10 @@ exports.cloneElement = function (element, config, children) {
owner = element._owner;
if (null != config) {
void 0 !== config.ref &&
(enableRefAsProp ||
((ref = config.ref), (ref = coerceStringRef(ref, owner, element.type))),
(owner = ReactSharedInternals.owner));
((owner = ReactSharedInternals.owner),
enableRefAsProp ||
((ref = config.ref),
(ref = coerceStringRef(ref, owner, element.type))));
void 0 !== config.key && (key = "" + config.key);
if (
!disableDefaultPropsExceptForClasses &&
Expand Down Expand Up @@ -690,4 +691,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-4b82ed06";
exports.version = "19.0.0-www-modern-0eabe82a";
9 changes: 5 additions & 4 deletions compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -461,9 +461,10 @@ exports.cloneElement = function (element, config, children) {
owner = element._owner;
if (null != config) {
void 0 !== config.ref &&
(enableRefAsProp ||
((ref = config.ref), (ref = coerceStringRef(ref, owner, element.type))),
(owner = ReactSharedInternals.owner));
((owner = ReactSharedInternals.owner),
enableRefAsProp ||
((ref = config.ref),
(ref = coerceStringRef(ref, owner, element.type))));
void 0 !== config.key && (key = "" + config.key);
if (
!disableDefaultPropsExceptForClasses &&
Expand Down Expand Up @@ -694,7 +695,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-classic-1e341207";
exports.version = "19.0.0-www-classic-aab80d0a";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
9 changes: 5 additions & 4 deletions compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -461,9 +461,10 @@ exports.cloneElement = function (element, config, children) {
owner = element._owner;
if (null != config) {
void 0 !== config.ref &&
(enableRefAsProp ||
((ref = config.ref), (ref = coerceStringRef(ref, owner, element.type))),
(owner = ReactSharedInternals.owner));
((owner = ReactSharedInternals.owner),
enableRefAsProp ||
((ref = config.ref),
(ref = coerceStringRef(ref, owner, element.type))));
void 0 !== config.key && (key = "" + config.key);
if (
!disableDefaultPropsExceptForClasses &&
Expand Down Expand Up @@ -694,7 +695,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.0.0-www-modern-1e341207";
exports.version = "19.0.0-www-modern-aab80d0a";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1767,6 +1767,8 @@ if (__DEV__) {

if (config != null) {
if (hasValidRef(config)) {
owner = ReactSharedInternals.owner;

if (!enableRefAsProp) {
// Silently steal the ref from the parent.
ref = config.ref;
Expand All @@ -1775,8 +1777,6 @@ if (__DEV__) {
ref = coerceStringRef(ref, owner, element.type);
}
}

owner = ReactSharedInternals.owner;
}

if (hasValidKey(config)) {
Expand Down Expand Up @@ -3083,7 +3083,7 @@ if (__DEV__) {

function noop() {}

var ReactVersion = "19.0.0-www-modern-f42736d9";
var ReactVersion = "19.0.0-www-modern-a3494f1d";

// Patch fetch
var Children = {
Expand Down
9 changes: 5 additions & 4 deletions compiled/facebook-www/ReactServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -439,9 +439,10 @@ exports.cloneElement = function (element, config, children) {
owner = element._owner;
if (null != config) {
void 0 !== config.ref &&
(enableRefAsProp ||
((ref = config.ref), (ref = coerceStringRef(ref, owner, element.type))),
(owner = ReactSharedInternals.owner));
((owner = ReactSharedInternals.owner),
enableRefAsProp ||
((ref = config.ref),
(ref = coerceStringRef(ref, owner, element.type))));
void 0 !== config.key && (key = "" + config.key);
if (
!disableDefaultPropsExceptForClasses &&
Expand Down Expand Up @@ -587,4 +588,4 @@ exports.useId = function () {
exports.useMemo = function (create, deps) {
return ReactSharedInternals.H.useMemo(create, deps);
};
exports.version = "19.0.0-www-modern-bd5b5e6e";
exports.version = "19.0.0-www-modern-3ff8d311";

0 comments on commit a85aedc

Please sign in to comment.