prep warnings

facebook · Dec 10, 2019 · b3bb398 · b3bb398
1 parent d901e39
commit b3bb398
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 19 deletions.
diff --git a/packages/shared/lowPriorityWarning.js b/packages/shared/lowPriorityWarning.js
@@ -18,13 +18,10 @@ import ReactSharedInternals from 'shared/ReactSharedInternals';
 let lowPriorityWarning = lowPriorityWarningWithoutStack;
 
 if (__DEV__) {
-  lowPriorityWarning = function(condition, format, ...args) {
-    if (condition) {
-      return;
-    }
+  lowPriorityWarning = function(format, ...args) {
     const ReactDebugCurrentFrame = ReactSharedInternals.ReactDebugCurrentFrame;
     const stack = ReactDebugCurrentFrame.getStackAddendum();
-    // eslint-disable-next-line react-internal/warning-and-invariant-args
+    // eslint-disable-next-line react-internal/warning-args
     lowPriorityWarningWithoutStack(false, format + '%s', ...args, stack);
   };
 }

diff --git a/packages/shared/lowPriorityWarningWithoutStack.js b/packages/shared/lowPriorityWarningWithoutStack.js
@@ -36,16 +36,15 @@ if (__DEV__) {
     } catch (x) {}
   };
 
-  lowPriorityWarningWithoutStack = function(condition, format, ...args) {
+  lowPriorityWarningWithoutStack = function(format, ...args) {
     if (format === undefined) {
       throw new Error(
         '`lowPriorityWarningWithoutStack(condition, format, ...args)` requires a warning ' +
           'message argument',
       );
     }
-    if (!condition) {
-      printWarning(format, ...args);
-    }
+
+    printWarning(format, ...args);
   };
 }
 

diff --git a/packages/shared/warning.js b/packages/shared/warning.js
@@ -18,13 +18,10 @@ import ReactSharedInternals from 'shared/ReactSharedInternals';
 let warning = warningWithoutStack;
 
 if (__DEV__) {
-  warning = function(condition, format, ...args) {
-    if (condition) {
-      return;
-    }
+  warning = function(format, ...args) {
     const ReactDebugCurrentFrame = ReactSharedInternals.ReactDebugCurrentFrame;
     const stack = ReactDebugCurrentFrame.getStackAddendum();
-    // eslint-disable-next-line react-internal/warning-and-invariant-args
+    // eslint-disable-next-line react-internal/warning-args
     warningWithoutStack(false, format + '%s', ...args, stack);
   };
 }

diff --git a/packages/shared/warningWithoutStack.js b/packages/shared/warningWithoutStack.js
@@ -6,7 +6,6 @@
  */
 
 /**
- * Similar to invariant but only logs a warning if the condition is not met.
  * This can be used to log issues in development environments in critical
  * paths. Removing the logging code for production environments will keep the
  * same logic and follow the same code paths.
@@ -15,7 +14,7 @@
 let warningWithoutStack = () => {};
 
 if (__DEV__) {
-  warningWithoutStack = function(condition, format, ...args) {
+  warningWithoutStack = function(format, ...args) {
     if (format === undefined) {
       throw new Error(
         '`warningWithoutStack(condition, format, ...args)` requires a warning ' +
@@ -28,9 +27,6 @@ if (__DEV__) {
         'warningWithoutStack() currently supports at most 8 arguments.',
       );
     }
-    if (condition) {
-      return;
-    }
     if (typeof console !== 'undefined') {
       const argsWithFormat = args.map(item => '' + item);
       argsWithFormat.unshift('Warning: ' + format);