[tests] assertLog before act in useEffectEvent (#28763)

Fixes tests blocking #28737
facebook · Apr 11, 2024 · ce262b1 · ce262b1
1 parent f9851d2
commit ce262b1
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/packages/react-reconciler/src/__tests__/useEffectEvent-test.js b/packages/react-reconciler/src/__tests__/useEffectEvent-test.js
@@ -742,7 +742,7 @@ describe('useEffectEvent', () => {
     await act(() =>
       ReactNoop.render(<ChatRoom roomId="general" theme="light" />),
     );
-    await act(() => jest.runAllTimers());
+
     assertLog(['Welcome to the general room!', 'Connected! theme: light']);
     expect(ReactNoop).toMatchRenderedOutput(
       <span prop="Welcome to the general room!" />,
@@ -752,20 +752,17 @@ describe('useEffectEvent', () => {
     await act(() =>
       ReactNoop.render(<ChatRoom roomId="music" theme="light" />),
     );
-    await act(() => jest.runAllTimers());
     assertLog([
       'Welcome to the music room!',
       // should trigger a reconnect
       'Connected! theme: light',
     ]);
-
     expect(ReactNoop).toMatchRenderedOutput(
       <span prop="Welcome to the music room!" />,
     );
 
     // change theme only
     await act(() => ReactNoop.render(<ChatRoom roomId="music" theme="dark" />));
-    await act(() => jest.runAllTimers());
     // should not trigger a reconnect
     assertLog(['Welcome to the music room!']);
     expect(ReactNoop).toMatchRenderedOutput(
@@ -776,7 +773,6 @@ describe('useEffectEvent', () => {
     await act(() =>
       ReactNoop.render(<ChatRoom roomId="travel" theme="dark" />),
     );
-    await act(() => jest.runAllTimers());
     assertLog([
       'Welcome to the travel room!',
       // should trigger a reconnect