Add comment

facebook · Jan 18, 2022 · d610003 · d610003
1 parent 2547b44
commit d610003
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js
@@ -714,6 +714,8 @@ function ensureRootIsScheduled(root: FiberRoot, currentTime: number) {
           // We don't support running callbacks in the middle of render
           // or commit so we need to check against that.
           if (executionContext === NoContext) {
+            // It's only safe to do this conditionally because we always
+            // check for pending work before we exit the task.
             flushSyncCallbacks();
           }
         });

diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js
@@ -714,6 +714,8 @@ function ensureRootIsScheduled(root: FiberRoot, currentTime: number) {
           // We don't support running callbacks in the middle of render
           // or commit so we need to check against that.
           if (executionContext === NoContext) {
+            // It's only safe to do this conditionally because we always
+            // check for pending work before we exit the task.
             flushSyncCallbacks();
           }
         });