Skip to content

Commit

Permalink
Remove redundant test steps (#26161)
Browse files Browse the repository at this point in the history
<!--
  Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please
provide enough information so that others can review your pull request.
The three fields below are mandatory.

Before submitting a pull request, please make sure the following is
done:

1. Fork [the repository](https://github.com/facebook/react) and create
your branch from `main`.
  2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch
TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It
supports the same options as `yarn test`.
6. If you need a debugger, run `yarn debug-test --watch TestName`, open
`chrome://inspect`, and press "Inspect".
7. Format your code with
[prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only
check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

Learn more about contributing:
https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

This TODO mentions an issue with JSDOM that [seems to have been
resolved](jsdom/jsdom#2996).

<!--
Explain the **motivation** for making this change. What existing problem
does the pull request solve?
-->

## How did you test this change?

- Ensured that the `document.activeElement` is no longer `node` after
`node.blur` is called.
- Verified that the tests still pass.
- Looked for [a merged PR that fixes the
issue](jsdom/jsdom#2996).

<!--
Demonstrate the code is solid. Example: The exact commands you ran and
their output, screenshots / videos if the pull request changes the user
interface.
How exactly did you verify that your PR solves the issue you wanted to
solve?
  If you leave this empty, your PR will very likely be closed.
-->

DiffTrain build for [fccf3a9](fccf3a9)
[View git log for this commit](https://github.com/facebook/react/commits/fccf3a9fba5fd778c678657c556344b333111cfb)
  • Loading branch information
eps1lon committed Feb 13, 2023
1 parent 7a9cb87 commit fb9dd9a
Show file tree
Hide file tree
Showing 28 changed files with 42 additions and 42 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
@@ -1 +1 @@
86c8c8db7938319027132eeea81c9b7e28938f9d
fccf3a9fba5fd778c678657c556344b333111cfb
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
86c8c8db7938319027132eeea81c9b7e28938f9d
fccf3a9fba5fd778c678657c556344b333111cfb
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-classic-fccf3a9fb-20230213";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-modern-fccf3a9fb-20230213";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Expand Up @@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-86c8c8db7-20230213";
exports.version = "18.3.0-www-classic-fccf3a9fb-20230213";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Expand Up @@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-86c8c8db7-20230213";
exports.version = "18.3.0-www-modern-fccf3a9fb-20230213";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Expand Up @@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-86c8c8db7-20230213";
exports.version = "18.3.0-www-classic-fccf3a9fb-20230213";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Expand Up @@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-86c8c8db7-20230213";
exports.version = "18.3.0-www-modern-fccf3a9fb-20230213";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.classic.js
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-classic-fccf3a9fb-20230213";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.modern.js
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-modern-fccf3a9fb-20230213";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Expand Up @@ -9844,7 +9844,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-86c8c8db7-20230213",
version: "18.3.0-www-classic-fccf3a9fb-20230213",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1318 = {
Expand Down Expand Up @@ -9875,7 +9875,7 @@ var internals$jscomp$inline_1318 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-86c8c8db7-20230213"
reconcilerVersion: "18.3.0-next-fccf3a9fb-20230213"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1319 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Expand Up @@ -9509,7 +9509,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-86c8c8db7-20230213",
version: "18.3.0-www-modern-fccf3a9fb-20230213",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1309 = {
Expand Down Expand Up @@ -9540,7 +9540,7 @@ var internals$jscomp$inline_1309 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-86c8c8db7-20230213"
reconcilerVersion: "18.3.0-next-fccf3a9fb-20230213"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1310 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.classic.js
Expand Up @@ -41945,7 +41945,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-classic-fccf3a9fb-20230213";

function createPortal(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.modern.js
Expand Up @@ -41669,7 +41669,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-modern-fccf3a9fb-20230213";

function createPortal(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Expand Up @@ -15435,7 +15435,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1743 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-86c8c8db7-20230213",
version: "18.3.0-www-classic-fccf3a9fb-20230213",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2106 = {
Expand Down Expand Up @@ -15465,7 +15465,7 @@ var internals$jscomp$inline_2106 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-86c8c8db7-20230213"
reconcilerVersion: "18.3.0-next-fccf3a9fb-20230213"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2107 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15713,4 +15713,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-86c8c8db7-20230213";
exports.version = "18.3.0-next-fccf3a9fb-20230213";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Expand Up @@ -14995,7 +14995,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1711 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-86c8c8db7-20230213",
version: "18.3.0-www-modern-fccf3a9fb-20230213",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2081 = {
Expand Down Expand Up @@ -15026,7 +15026,7 @@ var internals$jscomp$inline_2081 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-86c8c8db7-20230213"
reconcilerVersion: "18.3.0-next-fccf3a9fb-20230213"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2082 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15214,4 +15214,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-86c8c8db7-20230213";
exports.version = "18.3.0-next-fccf3a9fb-20230213";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Expand Up @@ -16205,7 +16205,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1817 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-86c8c8db7-20230213",
version: "18.3.0-www-classic-fccf3a9fb-20230213",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16249,7 +16249,7 @@ var devToolsConfig$jscomp$inline_1817 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-86c8c8db7-20230213"
reconcilerVersion: "18.3.0-next-fccf3a9fb-20230213"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -16484,7 +16484,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-86c8c8db7-20230213";
exports.version = "18.3.0-next-fccf3a9fb-20230213";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Expand Up @@ -15755,7 +15755,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1785 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-86c8c8db7-20230213",
version: "18.3.0-www-modern-fccf3a9fb-20230213",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -15800,7 +15800,7 @@ var devToolsConfig$jscomp$inline_1785 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-86c8c8db7-20230213"
reconcilerVersion: "18.3.0-next-fccf3a9fb-20230213"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
Expand Down Expand Up @@ -15975,7 +15975,7 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-86c8c8db7-20230213";
exports.version = "18.3.0-next-fccf3a9fb-20230213";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-classic-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-classic-fccf3a9fb-20230213";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-modern-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-modern-fccf3a9fb-20230213";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Expand Up @@ -3653,4 +3653,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-classic-86c8c8db7-20230213";
exports.version = "18.3.0-www-classic-fccf3a9fb-20230213";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Expand Up @@ -3561,4 +3561,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-modern-86c8c8db7-20230213";
exports.version = "18.3.0-www-modern-fccf3a9fb-20230213";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.classic.js
Expand Up @@ -31317,7 +31317,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-classic-fccf3a9fb-20230213";

function createPortal(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.modern.js
Expand Up @@ -37764,7 +37764,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-modern-fccf3a9fb-20230213";

function createPortal(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
Expand Up @@ -11555,7 +11555,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1538 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-86c8c8db7-20230213",
version: "18.3.0-www-classic-fccf3a9fb-20230213",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2057 = {
Expand Down Expand Up @@ -11585,7 +11585,7 @@ var internals$jscomp$inline_2057 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-86c8c8db7-20230213"
reconcilerVersion: "18.3.0-next-fccf3a9fb-20230213"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2058 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14763,4 +14763,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-86c8c8db7-20230213";
exports.version = "18.3.0-next-fccf3a9fb-20230213";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
Expand Up @@ -13870,7 +13870,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1666 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-86c8c8db7-20230213",
version: "18.3.0-www-modern-fccf3a9fb-20230213",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2044 = {
Expand Down Expand Up @@ -13901,7 +13901,7 @@ var internals$jscomp$inline_2044 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-86c8c8db7-20230213"
reconcilerVersion: "18.3.0-next-fccf3a9fb-20230213"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2045 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14232,4 +14232,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-86c8c8db7-20230213";
exports.version = "18.3.0-next-fccf3a9fb-20230213";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.classic.js
Expand Up @@ -23913,7 +23913,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-classic-fccf3a9fb-20230213";

// Might add PROFILE later.

Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.modern.js
Expand Up @@ -23913,7 +23913,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-86c8c8db7-20230213";
var ReactVersion = "18.3.0-www-modern-fccf3a9fb-20230213";

// Might add PROFILE later.

Expand Down

0 comments on commit fb9dd9a

Please sign in to comment.