Skip to content

Commit

Permalink
Fix failing Profiler tests
Browse files Browse the repository at this point in the history
The change to conditionally call Profiler commit hooks only if updates were scheduled broke a few of the Profiler tests. I've fixed the tests by either:
* Adding a no-op passive effect into the subtree or
* Converting onPostCommit to onCommit

When possible, I opted to add the no-op passive effect to the tests since that that hook is called later (during passive phase) so the test is a little broader. In a few cases, this required adding awkward act() wrappers so I opted to go with onCommit instead.
  • Loading branch information
Brian Vaughn committed Sep 22, 2020
1 parent df96450 commit fbb0375
Showing 1 changed file with 728 additions and 696 deletions.
Loading

0 comments on commit fbb0375

Please sign in to comment.