Skip to content

Commit

Permalink
Fix usage of console.error to prevent transform (#24188)
Browse files Browse the repository at this point in the history
We were suppressing the `react-internals/warning-args` lint rule
for the call to `console.error` in `defaultOnRecoverableError`.

As far as I could tell, the lint rule exists because on dev builds,
we replace all calls to `console.error` with [this error
function](https://github.com/facebook/react/blob/main/packages/shared/consoleWithStackDev.js#L31-L37)
which expects a format string + args and nothing else. We were trying
to pass in an `Error` object directly. After this commit's change,
we will still be passing an `Error` but the transform won't occur.
  • Loading branch information
yashsriv committed Mar 29, 2022
1 parent ba0aee5 commit fe6e074
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/react-dom/src/client/ReactDOMRoot.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ const defaultOnRecoverableError =
reportError
: (error: mixed) => {
// In older browsers and test environments, fallback to console.error.
// eslint-disable-next-line react-internal/no-production-logging, react-internal/warning-args
console.error(error);
// eslint-disable-next-line react-internal/no-production-logging
console['error'](error);
};

function ReactDOMRoot(internalRoot: FiberRoot) {
Expand Down

0 comments on commit fe6e074

Please sign in to comment.