Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a disclaimer to internal invariants #10285

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Add a disclaimer to internal invariants #10285

merged 1 commit into from
Jul 26, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 26, 2017

So that people don’t see just these messages if they run into bugs.

flarnie
flarnie approved these changes Jul 26, 2017
View reviewed changes
Copy link
Contributor

@flarnie flarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this only changes error copy and the changes lgtm I think this is ok.

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 26, 2017

I'll run tests and lint locally to verify

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 26, 2017

Tests and lint pass.

@gaearon gaearon merged commit ac76c95 into facebook:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flarnie flarnie flarnie approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaearon @flarnie @facebook-github-bot