Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in 16 beta: undefined is not a function (evaluating 'owner.getName()') #10443

Closed
sophiebits opened this issue Aug 11, 2017 · 6 comments
Closed

Comments

@sophiebits
Copy link
Collaborator

sophiebits commented Aug 11, 2017

This line is wrong in Fiber and crashes:

owner.getName() || 'A component',

It should be changed to use getComponentName(owner).

@iansu
Copy link
Contributor

iansu commented Aug 12, 2017

I'd like to take this issue.

@acdlite
Copy link
Collaborator

acdlite commented Aug 12, 2017

@iansu Cool, it's yours. This will help us release 16 stable.

fxfactorial added a commit to fxfactorial/react that referenced this issue Aug 12, 2017
fxfactorial added a commit to fxfactorial/react that referenced this issue Aug 12, 2017
fxfactorial added a commit to fxfactorial/react that referenced this issue Aug 12, 2017
@GabrielAmazonas
Copy link

Cool! I would like it too, but I have arrived too late

@sophiebits
Copy link
Collaborator Author

sophiebits commented Aug 12, 2017

Ahh @iansu it looks like we skipped over you after you claimed it. Really sorry about that.

@iansu @GabrielAmazonas Is one of you interested in writing a test that would have caught this? It can be added to src/renderers/native/__tests__/ReactNativeMount-test.js – try to trigger the warning and verify that console.error is called. There should be other tests you can use for checking a warning as an example.

@acdlite
Copy link
Collaborator

acdlite commented Aug 12, 2017

@iansu Oh I'm so sorry, I didn't realize it was a different person :( Should have paid closer attention, my bad

@GabrielAmazonas
Copy link

@acdlite! Yes, totally! Should I make a PR directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants