[Gatsby docs refactor] Make dev command more easily tested
#10786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** If we want to test across different devices, we need to set the `host` argument and tell Gatsby to listen on all ports. **why make this change?:** To be able to visit <my IP address>:8000 on another device and test the docs. **test plan:** Manually tested
|
Deploy preview ready! Built with commit 585e0e1 |
|
@flarnie I noticed there's also "yarn develop". Perhaps that should be changed to suit, as well? 🤔 |
|
Nice catch @joecritch ! Will fix.
|
bvaughn
reviewed
Sep 25, 2017
www/package.json
Outdated
| "lint": "./node_modules/.bin/eslint --ext .js,.jsx --ignore-pattern public .", | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "develop": "gatsby develop", | ||
| "develop": "gatsby develop -H 0.0.0.0", |
There was a problem hiding this comment.
Weird that we have both of these. That was an accident on my part. Let's just remove develop 😄
bvaughn
approved these changes
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
If we want to test across different devices, we need to set the
hostargument and tell Gatsby to listen on all ports.
why make this change?:
To be able to visit :8000 on another device and test the
docs.
test plan:
Manually tested