Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when component has PropTypes rather than propTypes #11510

Closed
gaearon opened this issue Nov 10, 2017 · 8 comments
Closed

Warn when component has PropTypes rather than propTypes #11510

gaearon opened this issue Nov 10, 2017 · 8 comments
Labels
Difficulty: starter good first issue (taken) Type: Enhancement

Comments

@gaearon
Copy link
Collaborator

gaearon commented Nov 10, 2017

See reactjs/react.dev#268 (comment).

Feels like an easy mistake to make, and easy for us to detect.
@M-ZubairAhmed
Copy link

hey can I take this ?

@blling
Copy link

blling commented Nov 10, 2017

@M-ZubairAhmed Just do it.

@M-ZubairAhmed
Copy link

could you please guide me to where to start with this issue? thank you

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 10, 2017

Search the code for where we read .propTypes and add the check there.

@M-ZubairAhmed
Copy link

got it.

@kotAPI
Copy link

kotAPI commented Nov 10, 2017

is this done?

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 10, 2017

It's taken by @M-ZubairAhmed.

@M-ZubairAhmed M-ZubairAhmed mentioned this issue Nov 11, 2017
Merged
5 tasks
@bs91
Copy link

bs91 commented Dec 5, 2017

@gaearon Should this be closed now?

@gaearon gaearon closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: starter good first issue (taken) Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bs91 @gaearon @kotAPI @M-ZubairAhmed @blling