Adds module and bundle type metadata to the rollup results json

[orta]

For #11865 - @gaearon and I discussed the idea of having smaller tables which were grouped by the module name. I had a think about how to do this with the current JSON but it currently looks like this:

{
  "bundleSizes": {
    "react.development.js (UMD_DEV)": {
      "size": 55220,
      "gzip": 14986
    },
    "react.production.min.js (UMD_PROD)": {
      "size": 6546,
      "gzip": 2789
    },
    "react.development.js (NODE_DEV)": {
      "size": 45636,
      "gzip": 12675
    },
    "react.production.min.js (NODE_PROD)": {
      "size": 5444,
      "gzip": 2373
    },
    "React-dev.js (FB_DEV)": {
      "size": 44974,
      "gzip": 12197
    },
    "React-prod.js (FB_PROD)": {
      "size": 12746,
      "gzip": 3440
    },

• I could grab the environment out of the name, but it'd be brittle.
• I could grab the module name from the string also, with some real funky string normalization, but that'd be even more brittle.

So instead I updated the results generator to include the actual package name and the environment it was built in. Making it more future proofed.

Made as a separate PR so that the PR #11865 can reference this in master.

[gaearon]

Let's just make the whole thing an array and add filename as one of the fields?

[orta]

Yep 👍

[orta]

Should I have the code handle both array types and object types?

for example http://react.zpao.com/builds/master/latest/results.json is still the older format, which is pulled in an used as the previous result

[gaearon]

Just array is fine. After you run yarn prettier and commit, CI won't fail so I can merge this, and then you'll see the array in master too.

[orta]

👍 cool cool, shipped

[gaearon]

OK, this fails CI but probably because master is not updated to use this format. So merging this should actually fix it..

[gaearon]

There were a few more issues but the master is green now so we should be good!

[orta]

Thanks Dan - sorry if I caused you anything serious!

…

-- [·/ ] Orta Therox w/ Artsy <http://artsy.net/> CocoaPods <http://cocoapods.org/> / CocoaDocs <http://cocoadocs.org/> @orta / orta.github.com

On Sat, Dec 23, 2017 at 8:27 PM, Dan Abramov ***@***.***> wrote: There were a few more issues but the master is green now so we should be good! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11914 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC_jlCFpdm_GjKwvlGwrroWDO9_wwfHks5tDaiTgaJpZM4RLbhS> .

[gaearon]

Not really, it's just scripts :-)