Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server integration tests for new context #12654

Merged
merged 3 commits into from
Apr 21, 2018
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 19, 2018

As I was investigating #12651 I noticed we didn't have the same kind of integration tests around hydration that we have for old context. This adds them.

const {
resetModules,
itRenders,
itThrowsWhenRendering,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not referenced ^

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small lint error and unnecessary contextTypes otherwise LGTM

);
}
}
ClassChildWithContext.contextTypes = {text: PropTypes.string};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

@gaearon gaearon merged commit c040bcb into facebook:master Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants