Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposed flushSync on the test renderer #12672

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Exposed flushSync on the test renderer #12672

merged 1 commit into from
Apr 23, 2018

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 23, 2018

I really need this method for writing async tests internally 馃槃

@bvaughn bvaughn requested review from flarnie and acdlite April 23, 2018 17:13
gaearon
gaearon approved these changes Apr 23, 2018
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@bvaughn bvaughn merged commit 149a34f into facebook:master Apr 23, 2018
@bvaughn bvaughn deleted the test-renderer-flush-sync branch April 23, 2018 17:27
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
@bvaughn
Exposed flushSync on the test renderer (#12672)
4724f7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@flarnie flarnie Awaiting requested review from flarnie

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bvaughn @gaearon @facebook-github-bot