Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FB www build of simple-cache-provider #12822

Merged
merged 1 commit into from
May 15, 2018
Merged

Add FB www build of simple-cache-provider #12822

merged 1 commit into from
May 15, 2018

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented May 15, 2018

No description provided.

@pull-bot
Copy link

Details of bundled changes.

Comparing: 369dd4f...abeea93

simple-cache-provider

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
SimpleCacheProvider-dev.js n/a n/a 0 B 6.08 KB 0 B 1.88 KB FB_WWW_DEV
SimpleCacheProvider-prod.js n/a n/a 0 B 2.69 KB 0 B 854 B FB_WWW_PROD

Generated by 🚫 dangerJS

bvaughn
bvaughn approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundle types change looks okay.

@acdlite acdlite merged commit a5184b2 into facebook:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@gaearon gaearon Awaiting requested review from gaearon

@flarnie flarnie Awaiting requested review from flarnie

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acdlite @pull-bot @bvaughn @facebook-github-bot