Quick fix for minor typo in ReactScheduler #12834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** We were setting a flag after some early returns, should have set it right away. To be fair, it's not clear how you can hit a problem with the current state of things. Even if a callback is cancelled, it's still in the 'pendingCallbacks' queue until the rAF runs, and we only schedule a rAF when there are pendingCallbacks in the queue. But since this is obviously wrong, going to fix it. We will be adding a regression test in a follow-up PR. **why make this change?:** To fix a random bug which was popping up. **test plan:** Adding a regression unit test in a follow-up PR.
|
Thanks @rhagigi for spotting this. |
acdlite
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
We were setting a flag after some early returns, should have set it
right away.
To be fair, it's not clear how you can hit a problem with the current
state of things. Even if a callback is cancelled, it's still in the
'pendingCallbacks' queue until the rAF runs, and we only schedule a rAF
when there are pendingCallbacks in the queue.
But since this is obviously wrong, going to fix it.
We will be adding a regression test in a follow-up PR.
why make this change?:
To fix a random bug which was popping up.
test plan:
Adding a regression unit test in a follow-up PR.