[simple-cache-provider] Use LRU cache eviction #12851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max size is hard-coded to 500. In the future, we should make this configurable per resource.
acdlite
force-pushed
the
simple-cache-provider-lru
branch
from
a3df513
to
3e44bf7
Compare
Details of bundled changes.Comparing: 40ea053...3b51dba simple-cache-provider
Generated by 🚫 dangerJS |
flarnie
approved these changes
May 26, 2018
| map: new Map(), | ||
| head: null, | ||
| tail: null, | ||
| size: 0, |
There was a problem hiding this comment.
Rather than keeping and updating the 'size' property here, could we rely on the size property of the map attribute of the cache?
There was a problem hiding this comment.
Going to land this PR, we can fix these in a follow-up.
| expect(IntegerStringResource.read(cache, 2)).toEqual('2'); | ||
| expect(IntegerStringResource.read(cache, 3)).toEqual('3'); | ||
|
|
||
| expect(() => IntegerStringResource.read(cache, 4)).toThrow(Promise); |
There was a problem hiding this comment.
Just one thing - I think even if 1, 2, and 3 are also evicted I think this will still pass. We could verify that those don't throw Promises?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max size is hard-coded to 500. In the future, we should make this configurable per resource.