Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ReactScheduler red->green unit test for bug fixed in #12834 #12861

Merged
merged 3 commits into from
May 18, 2018
Merged

Adds ReactScheduler red->green unit test for bug fixed in #12834 #12861

merged 3 commits into from
May 18, 2018

Conversation

rhagigi
Copy link
Contributor

@rhagigi rhagigi commented May 18, 2018

Verifies that work scheduled after the initial rAF but before the postMessage callback still runs and that more work can be scheduled after the fact.

@flarnie flarnie self-requested a review May 18, 2018 21:35
flarnie
flarnie approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@flarnie flarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Once lints/CI are passing feel free to squash-and-merge this.

@flarnie
Copy link
Contributor

flarnie commented May 18, 2018

One step that is not obvious is to run yarn prettier and it will format things with Prettier.

Also I can land this once CI is passing, whatever is more convenient.

@flarnie flarnie merged commit c0fe8d6 into facebook:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flarnie flarnie flarnie approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rhagigi @flarnie @facebook-github-bot