Retry on error if there's lower priority pending work #12957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to use this for suspending on error, too.
If an error is thrown, and there's lower priority work, it's possible the lower priority work will fix the error. Retry at the lower priority. If an error is thrown and there's no more work to try, handle the error like we normally do (trigger the nearest error boundary).
|
ReactDOM: size: 🔺+1.2%, gzip: 🔺+0.9% Details of bundled changes.Comparing: 36546b5...2755834 react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
Generated by 🚫 dangerJS |
|
Size change is because I had to move some stuff outside of the |
This was referenced May 31, 2018
sebmarkbage
approved these changes
Jun 13, 2018
|
@acdlite fyi - My sync yesterday didn't land, so planning on syncing this to Facebook first thing on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error is thrown, and there's lower priority work, it's possible the lower priority work will fix the error. Retry at the lower priority.
If an error is thrown and there's no more work to try, handle the error like we normally do (trigger the nearest error boundary).
This does not handle expiration correctly. If a priority level is suspended due to an error, the lower priority work should expire at the time of the suspended work. I'll work on this in a subsequent PR.