-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export createDOMComponentClass() #146
Comments
I agree this should be available and documented. |
👍 |
+1 to that. At the moment adding the missing svg tags is a bit pokey. |
FWIW, this won't help the JSX transformer which maintains it's own list of tags it recognizes and converts to React.DOM.* |
@zpao I'm sure the custom DOM nodes can be imported into the local scope, so when JSX converts them (like it does with React components), it will just work. In addition to SVG tags (which can all be supported by React eventually) there is also custom tags needed by legacy code, or proprietary systems. This is tags that will never be a part of React, and the only obvious alternative now (beside patching React) is to use So I'd be all for having a clean way to expand the supported DOM nodes with something like createDOMComponent. |
@sverrejoh As somebody who works on React, I'm saying that merely exposing this function doesn't add the tags to the JSX list. So if you want to be able to run React: https://github.com/facebook/react/blob/master/src/core/ReactDOM.js |
There's two separate issues here: allowing people to easily produce components corresponding to nonstandard tags, and making it so that As someone that doesn't use jsx (and likely never will), addressing the former by simply exporting |
@zpao @petehunt @sebmarkbage While I imagine 0.12 will make this happen, it does not address the issue of related attributes/properties that wouldn't be whitelisted right? |
Correct, we'll get there for attributes too though. |
At this point I think it's safe to say we'll never do this. |
On IRC today someone was missing a tag in ReactDOM. Should we export createDOMComponent() as an escape hatch?
The text was updated successfully, but these errors were encountered: