Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GCC #14657

Merged
merged 1 commit into from Jan 23, 2019
Merged

Bump GCC #14657

merged 1 commit into from Jan 23, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jan 22, 2019

Let's see if this works.

@gaearon
Copy link
Collaborator Author

gaearon commented Jan 22, 2019

@orta Any idea why Danger didn't run?

acdlite
acdlite approved these changes Jan 22, 2019
View reviewed changes
Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the test plan? If the production tests pass, can we assume everything's fine?

@gaearon
Copy link
Collaborator Author

gaearon commented Jan 23, 2019

Generally yes. (Although I'd also look at the built diff.)

I hoped to see a size comparison but for some reason there was none. Let me try locally.

@gaearon
Copy link
Collaborator Author

gaearon commented Jan 23, 2019

Oh maybe it's because there was zero change. 😄

@gaearon gaearon merged commit db695c4 into facebook:master Jan 23, 2019
@gaearon
Copy link
Collaborator Author

gaearon commented Jan 23, 2019

Apparently it had zero changes.

@gaearon gaearon deleted the bump-gcc-2 branch January 23, 2019 14:28
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@gaearon @n8schloss
Bump GCC (facebook#14657)
dbcc1a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaearon @acdlite @facebook-github-bot