Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shallow renderer doesn't update on setState() with Hooks #14840

Closed
gaearon opened this issue Feb 13, 2019 · 1 comment · Fixed by #15120
Closed

Shallow renderer doesn't update on setState() with Hooks #14840

gaearon opened this issue Feb 13, 2019 · 1 comment · Fixed by #15120
Labels
Component: Hooks Component: Shallow Renderer Type: Bug

Comments

@gaearon
Copy link
Collaborator

gaearon commented Feb 13, 2019

See the issue and the test case with original fix in #14802.

We'll need to fix it properly, see #14802 (comment).
@gaearon gaearon mentioned this issue Feb 13, 2019
Merged
@rodrigopr
Copy link
Contributor

I will try to take another look at this, starting with adjusting comments/code to align with new behavior.
You mentioned it might need a larger refactoring, do you have anything in mind? Should it be a part of this change?

@rodrigopr rodrigopr mentioned this issue Feb 13, 2019
Merged
@trueadm trueadm mentioned this issue Feb 13, 2019
Closed
@gaearon gaearon mentioned this issue Feb 18, 2019
Closed
@gaearon gaearon mentioned this issue Feb 27, 2019
Closed
13 tasks
@chenesan chenesan mentioned this issue Feb 28, 2019
Merged
7 tasks
ljharb pushed a commit to chenesan/enzyme that referenced this issue Mar 10, 2019
@chenesan @ljharb
[Tests] add mount-passing, shallow-failing test for useEffect hook
900f591 
Pending facebook/react#14840
ljharb pushed a commit to chenesan/enzyme that referenced this issue Mar 10, 2019
@chenesan @ljharb
[Tests] add mount-passing, shallow-failing test for useEffect hook
df0c326 
Pending facebook/react#14840
@gaearon gaearon mentioned this issue Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Hooks Component: Shallow Renderer Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Shallow] Implement setState for Hooks and remount on type change gaearon/react
2 participants
@rodrigopr @gaearon