[react-events] Keyboard calls preventDefault on 'click' events #16779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 137ea78...2353c0b react-events
|
trueadm
approved these changes
Sep 13, 2019
trueadm
reviewed
Sep 13, 2019
| @@ -150,6 +156,7 @@ function createKeyboardEvent( | |||
| isComposing, | |||
| key: getEventKey(nativeEvent), | |||
| metaKey, | |||
| pointerType: 'keyboard', | |||
There was a problem hiding this comment.
Do we really need a pointerType for keyboard responder?
trueadm
reviewed
Sep 13, 2019
| @@ -16,26 +16,32 @@ import React from 'react'; | |||
| import {DiscreteEvent} from 'shared/ReactTypes'; | |||
| import type {ReactEventResponderListener} from 'shared/ReactTypes'; | |||
|
|
|||
| type KeyboardEventType = 'keydown' | 'keyup'; | |||
| type KeyboardEventType = 'keyboard:keydown' | 'keyboard:keyup'; | |||
There was a problem hiding this comment.
I guess the keyboard prefix is because we're also adding the keyboard pointer type. What do you expect this to expand to in the future?
There was a problem hiding this comment.
I think we should scope event names to their responder, especially given that keydown and keyup are also the names of native events
Make sure to call preventDefault for any 'click' events that follow a 'keydown' event that matches 'preventKeys'
necolas
force-pushed
the
react-events/use-keyboard-prevents-click
branch
from
a3214b0
to
2353c0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to call preventDefault for any 'click' events that follow a 'keydown'
event that matches 'preventKeys'.