Extract some of the tidy up changes from 19278 #19315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
rickhanlonii
approved these changes
Jul 10, 2020
| ); | ||
| } else if (isValidEventTarget(target)) { | ||
| const eventTarget = ((target: any): EventTarget); | ||
| const listenerMap = getEventListenerMap(eventTarget); | ||
| listenToTopLevelEvent( | ||
| listenToNativeEvent( | ||
| topLevelType, |
There was a problem hiding this comment.
Should this change to nativeEventType then?
There was a problem hiding this comment.
Dan's further change to remove the concept topLevelType will address this.
Details of bundled changes.Comparing: a2b4db0...2d8d1fd react-dom
Size changes (stable) |
Details of bundled changes.Comparing: a2b4db0...2d8d1fd react-dom
Size changes (experimental) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2d8d1fd:
|
trueadm
force-pushed
the
clean-up-event-system
branch
2 times, most recently
from
5ca4f6f
to
4064c18
Compare
Add Flow changes Add Flow changes Add Flow changes Add Flow changes
trueadm
force-pushed
the
clean-up-event-system
branch
from
4064c18
to
2d8d1fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make #19278 a bit smaller in terms of changes, this extracts some of the tidy up changes from that PR. #19278 should now only refer to the changes reflecting to moving away from capture phase events.