Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for the svg stroke-linejoin attribute #2103

Closed
marklundin opened this issue Aug 28, 2014 · 2 comments
Closed

No support for the svg stroke-linejoin attribute #2103

marklundin opened this issue Aug 28, 2014 · 2 comments
Labels

Comments

@marklundin
Copy link

Currently there is no support for the stroke-linejoin attribute on svg elements. The stroke-linecap has been implemented, but the line join is just as important.

You can see the difference here; http://jsbin.com/vipowiqebipa/6/edit

@syranide
Copy link
Contributor

syranide commented Oct 8, 2014

Please submit this to #1657 instead.

@gaearon
Copy link
Collaborator

gaearon commented Dec 25, 2015

This should be fixed by #5714.

@gaearon gaearon closed this as completed Dec 25, 2015
josephsavona added a commit that referenced this issue May 15, 2024
This is a redo of #1640 now that we've established the necessary infrastructure, 
most notably `Effect.ConditionallyMutate` and `noAlias` from #2103 earlier in 
this stack. We can now understand the semantics of hooks that return deeply 
readonly values composed of primitives, arrays, or objects such that any 
`.map()` or `.filter()` calls are guaranteed to be the corresponding array 
methods. That further allows us to refine, since we know that the lambdas passed 
to these calls can't alias, are conditionally mutable, etc. All in all this 
should let us memoize less in practice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants