[Scheduler] Check for continuous input events #22107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in `shouldYield`, we compare the current time to a deadline that is pre-computed at the beginning of the current chunk. However, since we use different deadlines depending on whether an input event is pending, it makes more sense to track the start of the current chunk and check how much time has elapsed since then. Doesn't change any behavior, just refactors the logic.
`isInputPending` supports a `includeContinuous` option. When set to `true`, the method will check for pending continuous inputs, like `mousemove`, in addition to discrete ones, like `click`. We will only check for pending continuous inputs if we've blocked the main thread for a non-neglible amount of time. If we've only blocked the main thread for, say, a few frames, then we'll only check for discrete inputs. I wrote a test for this but didn't include it because we haven't yet set up the `gate` flag infra to work with Scheduler feature flags. For now, I ran the test locally.
facebook-github-bot
added
CLA Signed
React Core Team
|
cc: @acomminos GitHub wouldn't let me request a review from you for some reason |
acdlite
force-pushed
the
scheduler-check-for-continuous
branch
from
b158495
to
5b81d30
Compare
|
Comparing: 152ecce...5cce438 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
acdlite
force-pushed
the
scheduler-check-for-continuous
branch
from
5b81d30
to
e28bcce
Compare
acomminos
approved these changes
Aug 16, 2021
| } else if (timeElapsed < maxInterval) { | ||
| // Yield if there's either a pending discrete or continuous input. | ||
| if (isInputPending !== null) { | ||
| return isInputPending({includeContinuous: true}); |
There was a problem hiding this comment.
Can we declare the arg above as continuousOptions (or something similar) in module scope to avoid an object allocation each call?
| @@ -499,7 +515,7 @@ const performWorkUntilDeadline = () => { | |||
| // Yield after `yieldInterval` ms, regardless of where we are in the vsync | |||
There was a problem hiding this comment.
I think this comment needs to be updated :)
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Aug 17, 2021
Summary: This sync includes the following changes: - **[424fe5870](facebook/react@424fe5870 )**: Revert "Show a soft error when a text string or number is supplied as a child to non text wrappers ([#21953](facebook/react#21953))" ([#22108](facebook/react#22108)) //<Sota>// - **[aebf3b456](facebook/react@aebf3b456 )**: [Scheduler] Check for continuous input events ([#22107](facebook/react#22107)) //<Andrew Clark>// - **[e9b2028b3](facebook/react@e9b2028b3 )**: Show a soft error when a text string or number is supplied as a child to non text wrappers ([#21953](facebook/react#21953)) //<Sota>// - **[ecd73e17b](facebook/react@ecd73e17b )**: Enable enableSuspenseLayoutEffectSemantics flag statically for Facebook ([#22050](facebook/react#22050)) //<Brian Vaughn>// - **[a8725a3e6](facebook/react@a8725a3e6 )**: Scheduling profiler: Added lane labels and durations to React measures ([#22029](facebook/react#22029)) //<Brian Vaughn>// Changelog: [General][Changed] - React Native sync for revisions 19092ac...5634ed1 jest_e2e[run_all_tests] Reviewed By: kacieb Differential Revision: D30225923 fbshipit-source-id: 562895d3e0d264f40770dadb89d4a16241967c4c
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* [Scheduler] Track start of current chunk Currently in `shouldYield`, we compare the current time to a deadline that is pre-computed at the beginning of the current chunk. However, since we use different deadlines depending on whether an input event is pending, it makes more sense to track the start of the current chunk and check how much time has elapsed since then. Doesn't change any behavior, just refactors the logic. * [Scheduler] Check for continuous input events `isInputPending` supports a `includeContinuous` option. When set to `true`, the method will check for pending continuous inputs, like `mousemove`, in addition to discrete ones, like `click`. We will only check for pending continuous inputs if we've blocked the main thread for a non-neglible amount of time. If we've only blocked the main thread for, say, a few frames, then we'll only check for discrete inputs. I wrote a test for this but didn't include it because we haven't yet set up the `gate` flag infra to work with Scheduler feature flags. For now, I ran the test locally. * Review nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isInputPendingsupports aincludeContinuousoption. When set totrue, the method will check for pending continuous inputs, likemousemove, in addition to discrete ones, likeclick.We will only check for pending continuous inputs if we've blocked the main thread for a non-negligible amount of time. If we've only blocked the main thread for, say, a few frames, then we'll only check for discrete inputs.
I wrote a test for this but didn't include it because we haven't yet set up the
gateflag infra to work with Scheduler feature flags. For now, I ran the test locally.