Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools Bug]: DevTools shouldn't skip over keyed Fragments in the tree #25187

Closed
gaearon opened this issue Sep 5, 2022 · 1 comment · Fixed by #25197
Closed

[DevTools Bug]: DevTools shouldn't skip over keyed Fragments in the tree #25187

gaearon opened this issue Sep 5, 2022 · 1 comment · Fixed by #25197
Labels
Component: Developer Tools Type: Bug

Comments

@gaearon
Copy link
Collaborator

gaearon commented Sep 5, 2022

Website or app

reactjs/react.dev#4981

Repro steps

  1. Wrap something into <Fragment key="stuff">
  2. It doesn't show up in DevTools

We filter out fragments because they tend to be useless. But this one is important! Keys are crucial and we should show anything with a key in the tree.

How often does this bug happen?

Every time

DevTools package (automated)

No response

DevTools version (automated)

No response

Error message (automated)

No response

Error call stack (automated)

No response

Error component stack (automated)

No response

GitHub query string (automated)

No response
@gaearon gaearon added Type: Bug Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Component: Developer Tools labels Sep 5, 2022
@gaearon gaearon mentioned this issue Sep 5, 2022
Merged
@timagixe
Copy link

timagixe commented Sep 5, 2022

Hi @gaearon, I would like to give it a shot, if you think this bug is a beginner friendly.

Could you please point which exact package should I look at? I see there are seven of them related to devtools:

react-devtools-core
react-devtools-extensions
react-devtools-inline
react-devtools-shared
react-devtools-shell
react-devtools-timeline
react-devtools

@lunaruan lunaruan removed the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Sep 6, 2022
@lunaruan lunaruan mentioned this issue Sep 7, 2022
Merged
lunaruan added a commit that referenced this issue Sep 7, 2022
@lunaruan
[DevTools][Bugfix] Don't hide fragment if it has a key (#25197)
c80e541 
resolves #25187

---

We shouldn't hide fragments that have a key because this is important information that the user might want in the future.
sammy-SC pushed a commit that referenced this issue Sep 11, 2022
@lunaruan @sammy-SC
[DevTools][Bugfix] Don't hide fragment if it has a key (#25197)
a78c298 
resolves #25187

---

We shouldn't hide fragments that have a key because this is important information that the user might want in the future.
rickhanlonii pushed a commit that referenced this issue Oct 5, 2022
@lunaruan @rickhanlonii
[DevTools][Bugfix] Don't hide fragment if it has a key (#25197)
72f5995 
resolves #25187

---

We shouldn't hide fragments that have a key because this is important information that the user might want in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Developer Tools Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DevTools][Bugfix] Don't hide fragment if it has a key lunaruan/react
3 participants
@gaearon @lunaruan @timagixe