Bug(@next): legacy ReactDOM.render crashes when rendering into document container
#26128
Labels
Comments
eps1lon
changed the title
ReactDOM.render crashes when rendering into document containerReactDOM.render crashes when rendering into document container
I do believe the flag is on for the oss-stable build so it makes sense the code is showing up. I'll add a test and fix once I repro |
Oh right. It was initially shipped with |
gnoff
added a commit
that referenced
this issue
Feb 8, 2023
as reported in #26128 `ReactDOM.render(..., document)` crashed when `enableHostSingletons` was on. This is because it had a different way of clearing the container than `createRoot(document)`. I updated the legacy implementation to share the clearing behavior of `creatRoot` which will preserve the singleton instances. I also removed the warning saying not to use `document.body` as a container
github-actions bot
pushed a commit
that referenced
this issue
Feb 8, 2023
as reported in #26128 `ReactDOM.render(..., document)` crashed when `enableHostSingletons` was on. This is because it had a different way of clearing the container than `createRoot(document)`. I updated the legacy implementation to share the clearing behavior of `creatRoot` which will preserve the singleton instances. I also removed the warning saying not to use `document.body` as a container DiffTrain build for [a3152ed](a3152ed) [View git log for this commit](https://github.com/facebook/react/commits/a3152eda5f89e20f056521855f7fa101ce50e4c3)
|
Fixed in #26129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
React version: 18.3.0-next-4bf2113a1-20230206
Steps To Reproduce
ReactDOM.renderinto adocumentcontainerLink to code example: https://codesandbox.io/s/react-next-legacy-render-crashes-when-rendering-html-jqdut3?file=/src/index.js
The current behavior
Throws with
ReactDOM.renderclears the container before rendering into it. But with the new HostSingletons (#25426) we expect an existingdocumentElement.The odd part is that it seems like #25426 affected the
@nextrelease even thoughenableHostSingletonsis disabled for that release./cc @gnoff
The expected behavior
No crash like in
react-dom@18.2.0: https://codesandbox.io/s/react-next-legacy-render-crashes-when-rendering-html-forked-977biyThe text was updated successfully, but these errors were encountered: