Update examples for Babel, 0.14; remove 3rd party code #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,23 +11,25 @@ | |||
| <p> | |||
| If you can see this, React is not running. Try running: | |||
| </p> | |||
| <pre>npm install -g react-tools | |||
There was a problem hiding this comment.
What was wrong with this? Your way gives extra whitespace.
There was a problem hiding this comment.
Nothing I just wanted prettier HTML. Comparing styling now though, looks like leaving as purely pre will be better.
|
👍 |
zpao
added a commit
that referenced
this pull request
Sep 24, 2015
Update examples for Babel, 0.14; remove 3rd party code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple changes here. The most important are that this brings us up to compatibility with 0.14 (mostly just using
ReactDOMwhere appropriate). The other thing is that we stop trying to use JSXTransformer, which we aren't even building so these are all broken right now. And lastly, I took this opportunity to stop bundling 3rd party code (es5-shim, sham, console, jquery, bootstrap) and just point at CDNs. This does mean that the examples will require an internet connection to actually run but I think that's ok - I don't care about the airplane case as much anymore.I left the server-rendering example alone because I think I want to delete it. It's confusing to follow and run, and I think there are enough resources around on server rendering.