Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX tool return zero on error #615

Closed
arsfeld opened this issue Nov 26, 2013 · 1 comment · Fixed by #783
Closed

JSX tool return zero on error #615

arsfeld opened this issue Nov 26, 2013 · 1 comment · Fixed by #783

Comments

@arsfeld
Copy link

arsfeld commented Nov 26, 2013

I'm using the JSX tool in an automated build system and I want to check for errors compiling JSX files, but instead of returning a non-zero error code, the jsx command just writes everything to stderr and exits with a zero error code.
What is even worse, stderr is used when the build is successfull as well, forcing me to parse it's stderr output to check for an error.

@zpao
Copy link
Member

zpao commented Nov 27, 2013

Good point! We use an intermediate tool that does caching and some other smart things. I'm going to pass this off to @benjamn because he's the author of commoner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants