Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin/jsx should not relativize required module IDs unless --relativize is passed #80

Closed
benjamn opened this issue Jun 11, 2013 · 2 comments · Fixed by #81
Closed

bin/jsx should not relativize required module IDs unless --relativize is passed #80

benjamn opened this issue Jun 11, 2013 · 2 comments · Fixed by #81
Assignees
@benjamn
Labels
Type: Enhancement

Comments

@benjamn
Copy link
Contributor

benjamn commented Jun 11, 2013

Inspired by #71 (comment)

This will reduce the number of assumptions imposed by bin/jsx considerably.

We should still use --relativize for our grunt tasks, but that's our poison to pick.

cc @petehunt @zpao
@ghost ghost assigned benjamn Jun 11, 2013
@benjamn
Copy link
Contributor Author

benjamn commented Jun 11, 2013

Commoner task: https://github.com/benjamn/commoner/issues/28

@zpao
Copy link
Member

zpao commented Jun 11, 2013

👍

benjamn added a commit to benjamn/react that referenced this issue Jun 11, 2013
@benjamn
Upgrade Commoner and Recast to latest versions.
1536005 
The Commoner upgrade is a big one because it makes bin/jsx no longer
rewrite module identifiers to be relative by default, which should
reduce confusion for people trying to use it as a standalone
transformer.

Closes facebook#80.
@benjamn benjamn mentioned this issue Jun 11, 2013
Merged
benjamn added a commit that referenced this issue Jun 20, 2013
@benjamn @zpao
Upgrade Commoner and Recast to latest versions.
3624afa 
The Commoner upgrade is a big one because it makes bin/jsx no longer
rewrite module identifiers to be relative by default, which should
reduce confusion for people trying to use it as a standalone
transformer.

Closes #80.
(cherry picked from commit 1536005)
taneliang referenced this issue in MLH-Fellowship/react Aug 17, 2020
@taneliang
Reimplement canvas using view classes (#80)
e55e8ea 
Replaces Brian's original procedural code with view classes. The views are rudimentary implementations of iOS UIKit-style UIViews.
taneliang referenced this issue in MLH-Fellowship/react Aug 17, 2020
@taneliang
[Improve base View][1/n] Add subview handling to View (#99)
4d47600 
Summary

This PR begins a stack of PRs that improves the base `View` class
implemented in #80.

This PR adds subview management to `View`, as there was a lot of
duplicated subview handling code present in almost all our `View`
subclasses. This also brings us closer to UIKit's `UIView`, which
also handles its own subviews.

Implements #95.

Test Plan

* `yarn start`: nothing broken
* `yarn lint`
* `yarn flow`: no errors in affected code
* `yarn test`
taneliang referenced this issue in MLH-Fellowship/react Aug 19, 2020
@taneliang
Reimplement canvas using view classes (#80)
19b1fcf 
Replaces Brian's original procedural code with view classes. The views are rudimentary implementations of iOS UIKit-style UIViews.
taneliang referenced this issue in MLH-Fellowship/react Aug 19, 2020
@taneliang
[Improve base View][1/n] Add subview handling to View (#99)
4385a12 
Summary

This PR begins a stack of PRs that improves the base `View` class
implemented in #80.

This PR adds subview management to `View`, as there was a lot of
duplicated subview handling code present in almost all our `View`
subclasses. This also brings us closer to UIKit's `UIView`, which
also handles its own subviews.

Implements #95.

Test Plan

* `yarn start`: nothing broken
* `yarn lint`
* `yarn flow`: no errors in affected code
* `yarn test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamn benjamn

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Commoner and Recast to latest versions benjamn/react
2 participants
@benjamn @zpao