Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15.4 minor wasn't supposed to break so much stuff, was it? #8303

Closed
TCMiranda opened this issue Nov 16, 2016 · 2 comments
Closed

15.4 minor wasn't supposed to break so much stuff, was it? #8303

TCMiranda opened this issue Nov 16, 2016 · 2 comments

Comments

@TCMiranda
Copy link

screenshot from 2016-11-16 14-38-06

Some packages broke due to missing stuffs on react/lib/...
Seems like it shouldn't happen, even my build process broke suddenly due to react 15.4 update (react packages set to ^15.3.2)

Thanks!

@TCMiranda TCMiranda changed the title 15.4 minor wasn't suppose to break so much stuff, was it? 15.4 minor wasn't supposed to break so much stuff, was it? Nov 16, 2016
@gaearon
Copy link
Collaborator

gaearon commented Nov 16, 2016

Hi, thanks for the report.

If you rely on packages that rely on undocumented or private APIs, consider keeping React version pinned. It is never safe to rely on internal APIs and we never supported this officially. We can't consider private APIs as part of semver because there is no way to tell if any particular change in the internals would break a library reaching into them. This is just an unsupported way of using React.

We asked people to test 15.4 RC for a month: #7770 (comment). Unfortunately there is nothing we can do to force libraries using private APIs to stop doing this until we start using flat bundles.

Please reach out to maintainers of https://github.com/zilverline/react-tap-event-plugin and ask them to get zilverline#82 merged. But it might break later again because reaching into internal APIs is just not supported, and never has been.

@gaearon gaearon closed this as completed Nov 16, 2016
@sophiebits
Copy link
Collaborator

Same with the authors of draft-js-export-html (not a Facebook-owned module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants