Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component stack to the contentEditable warning #8497

Closed
ghost opened this issue Dec 5, 2016 · 4 comments
Closed

Add component stack to the contentEditable warning #8497

ghost opened this issue Dec 5, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 5, 2016

feature

Warning: A component is contentEditable and contains children managed by React. It is now your responsibility to guarantee that none of those nodes are unexpectedly modified or duplicated. This is probably not intentional.

It would help heaps if I would know which component is causing this.

@gaearon gaearon changed the title contentEditable warning should say which Component causes the error. Add component stack to the contentEditable warning Oct 4, 2017
@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2017

We should add component stack to it, just like other warnings have it.

@Ethan-Arrowood
Copy link
Contributor

@gaearon I'd like to try this one out. I'm a first-time contributor for the React project so some more pointers would be appreciated!

@gaearon
Copy link
Collaborator

gaearon commented Oct 5, 2017

Here is an example of a warning that includes component stack. Here is how we test such warnings.

Here is the contentEditable warning. As you see, it doesn't include the stack. Add it there. Here is the relevant test. Change it to also test the warning message (not just a single word like now) and for the presence of the stack.

Hope this helps!

@Ethan-Arrowood
Copy link
Contributor

👍 Thank you! I'll give it a shot later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants