Add component stack to uncontrolled-to-controlled warning #9416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
approved these changes
Apr 14, 2017
| @@ -1003,7 +1022,7 @@ describe('ReactDOMInput', () => { | |||
| ); | |||
| ReactDOM.render(<input type="radio" value="value" />, container); | |||
| expectDev(console.error.calls.argsFor(0)[0]).toContain( | |||
| 'A component is changing a controlled input of type radio to be uncontrolled. ' + | |||
| 'Warning: A component is changing a controlled input of type radio to be uncontrolled. ' + | |||
| 'Input elements should not switch from controlled to uncontrolled (or vice versa). ' + | |||
| 'Decide between using a controlled or uncontrolled input ' + | |||
| 'element for the lifetime of the component. More info: https://fb.me/react-controlled-components', | |||
There was a problem hiding this comment.
nit: Curious why we're checking the stack portion in all of the above tests but not this one
There was a problem hiding this comment.
Sloppy editing on my part, I'll fix.
sophiebits
force-pushed
the
wstack-uncontrolled-change
branch
from
752d3e1
to
cc82c2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twitter.com/JulianVModesto/status/836089555304448000
https://twitter.com/abevoelker/status/836040051993763842