Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component stack to ReactControlledValuePropTypes #9435

Merged
merged 1 commit into from
Apr 15, 2017

Conversation

sophiebits
Copy link
Collaborator

No description provided.

@gaearon
Copy link
Collaborator

gaearon commented Apr 15, 2017

If we're getting rid of "Check the render method", should we encourage people to use the jsx-source plugin more broadly? Unfortunately we don't include it in development in react preset because we don't have a sure way to tell if the user is in development or not.

@sophiebits
Copy link
Collaborator Author

The stack without jsx-source is still more informative than "Check the render method".

@aweary
Copy link
Contributor

aweary commented Apr 15, 2017

What if it displayed some information on including jsx-source if __source isn't available?

Include the babel-plugin-transform-react-jsx-source plugin in your Babel development config to get a full trace of this warning.

Or something less verbose with a link.

@sophiebits
Copy link
Collaborator Author

I'm torn. You wouldn't have line info if you don't use JSX and on frames containing third-party components.

@gaearon
Copy link
Collaborator

gaearon commented Apr 15, 2017

The stack without jsx-source is still more informative than "Check the render method".

Ah, I haven't thought about it. 👍

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the more places we include the component stack-the better. Just gave this a quick test locally and it looks nice.

@sophiebits sophiebits merged commit 7bf686b into facebook:master Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants