Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre format only compile time errors #9538

Merged
merged 2 commits into from Apr 27, 2017

Conversation

tsriram
Copy link
Contributor

@tsriram tsriram commented Apr 27, 2017

This fixes the behavior changed by #9497 for #9479.

Now it renders only the compile time error messages in <pre> and runtime messages as before in a div which wraps text.

Compile error:
compile_error

Runtime error:
runtime

@gaearon gaearon merged commit 70c0196 into facebook:master Apr 27, 2017
@tsriram tsriram deleted the fix/error-formatting branch April 27, 2017 15:11
gaearon pushed a commit that referenced this pull request May 1, 2017
* pre format only compile time errors

* Style tweak

(cherry picked from commit 70c0196)
flarnie pushed a commit that referenced this pull request Jun 12, 2017
* pre format only compile time errors

* Style tweak

(cherry picked from commit 70c0196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants