-
Notifications
You must be signed in to change notification settings - Fork 45.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG for unreleased 15.6 branch #9827
Conversation
CHANGELOG.md
Outdated
* Fix issue where environment variable was not being transformed by browserify. ([@mridgway](https://github.com/mridgway) in [#9642](https://github.com/facebook/react/pull/9642)) | ||
* Add deprecation warnings and separate module for React.DOM factory helpers. ([@nhunzaker](https://github.com/nhunzaker) in [#8356](https://github.com/facebook/react/pull/8356)) | ||
* Add deprecation warning for React.createClass helper. ([@nhunzaker](https://github.com/nhunzaker) in [#8356](https://github.com/facebook/react/pull/8356)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deprecation warning added in this PR is about DOM factories rather than createClass
. Did you tag the wrong PR? Seems like this meant to go with the line above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks! I didn't mean to add that line at all - since the createClass
deprecation warning was noted in the 15.5 changelog we don't need to say it again, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except the one PR link!
2c3e384
to
e7bdfdc
Compare
**what is the change?:** Added entries for the latest changes. **why make this change?:** We are about to do an RC release and folks can look at these notes to see what is in the planned release. **test plan:** Visual inspection **issue:** facebook#9398
e7bdfdc
to
f96f4ca
Compare
**what is the change?:** We decided to strike through the previous changelog item and add it to the more recent changelog section, since this is the release where the deprecation warning will actually go out. **why make this change?:** To make things clear for everyone using 15.6 **test plan:** Visual inspection **issue:** facebook#9398
@TrySound nice catch! I'll update that now. |
what is the change?:
Added entries for the latest changes.
why make this change?:
We are about to do an RC release and folks can look at these notes to
see what is in the planned release.
test plan:
Visual inspection
issue:
#9398