Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use ES modules internally #10524

Closed
wants to merge 27 commits into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Aug 23, 2017

Based on top of https://github.com/facebook/react/pulls.

This is probably broken in some ways (and definitely breaks Jest) but some test displays Hello World. Builds are a few KBs down.

Probably don't want to land this until we have a way to run tests against bundles. Still was fun try. I intend to keep this (relatively) up to date hoping I can land it within a few weeks once the infra is there.

@acdlite
Copy link
Collaborator

acdlite commented Aug 23, 2017

Cool! How did you convert

if (__DEV__) {
  var warning = require('warning');
}

?

@nhunzaker
Copy link
Contributor

27,000 deletions. Why such a stark drop?

@sophiebits
Copy link
Collaborator

It's stacked (ha) on #10517.

@nhunzaker
Copy link
Contributor

Oh. Haha. @spicyj so clever!

@gaearon
Copy link
Collaborator Author

gaearon commented Aug 24, 2017

@acdlite For now I just turned everything into imports so there might be DEV-only things there. I have a list of them. We can do something like #10176 (comment) as this gets closer to reality. I think the bigger blocker is lack of test infra.

They weren't necessary and made things more confusing.
@gaearon
Copy link
Collaborator Author

gaearon commented Nov 21, 2017

Did this in another PR.

@gaearon gaearon closed this Nov 21, 2017
@gaearon gaearon deleted the remove-dom-stack+esm branch November 21, 2017 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants