Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stack (part 1, safe: unused files and tests) #10794

Merged
merged 4 commits into from Sep 27, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 23, 2017

This is extracted from #10517.
This is safe to merge because it only touches:

  • Tests.
  • Files that were not used anywhere (these are now deleted).

If any of those files were still used, the build would break.
I have verified yarn build produces identical build on master and in this branch for all files.

For convenience, here is the git status before commit:

  # jest config
  modified:   package.json
  deleted:    scripts/jest/fiber.config.json
  renamed:    scripts/jest/fiber.setup.js -> scripts/jest/setup.js
  deleted:    scripts/jest/stack.config.json
  deleted:    scripts/jest/stack.setup.js


  # updated PooledClass folder (only used by RN)
  modified:   scripts/rollup/packaging.js


  # jest shims
  modified:   src/node_modules/react-dom/index.js
  modified:   src/node_modules/react-dom/server.browser.js
  modified:   src/node_modules/react-dom/server.js


  # tests
  modified:   src/renderers/__tests__/refs-test.js


  # dead stack entry points
  deleted:    src/renderers/dom/ReactDOMServerStackEntry.js
  deleted:    src/renderers/dom/ReactDOMStackEntry.js


  # tests
  modified:   src/renderers/dom/shared/__tests__/ReactServerRendering-test.js


  # dead stack code
  deleted:    src/renderers/dom/stack/client/DOMChildrenOperations.js
  deleted:    src/renderers/dom/stack/client/DOMLazyTree.js
  deleted:    src/renderers/dom/stack/client/Danger.js
  deleted:    src/renderers/dom/stack/client/ReactComponentBrowserEnvironment.js
  deleted:    src/renderers/dom/stack/client/ReactDOMComponent.js
  deleted:    src/renderers/dom/stack/client/ReactDOMContainerInfo.js
  deleted:    src/renderers/dom/stack/client/ReactDOMEmptyComponent.js
  deleted:    src/renderers/dom/stack/client/ReactDOMIDOperations.js
  deleted:    src/renderers/dom/stack/client/ReactDOMStackInjection.js
  deleted:    src/renderers/dom/stack/client/ReactDOMTextComponent.js
  deleted:    src/renderers/dom/stack/client/ReactMount.js
  deleted:    src/renderers/dom/stack/client/ReactReconcileTransaction.js
  deleted:    src/renderers/dom/stack/client/wrappers/ReactDOMInput.js
  deleted:    src/renderers/dom/stack/client/wrappers/ReactDOMOption.js
  deleted:    src/renderers/dom/stack/client/wrappers/ReactDOMSelect.js
  deleted:    src/renderers/dom/stack/client/wrappers/ReactDOMTextarea.js
  deleted:    src/renderers/dom/stack/server/ReactMarkupChecksum.js
  deleted:    src/renderers/dom/stack/server/ReactServerBatchingStrategy.js
  deleted:    src/renderers/dom/stack/server/ReactServerRendering.js
  deleted:    src/renderers/dom/stack/server/ReactServerRenderingTransaction.js
  deleted:    src/renderers/dom/stack/server/ReactServerUpdateQueue.js


  # moved PooledClass (only used by RN)
  renamed:    src/renderers/shared/stack/PooledClass.js -> src/renderers/native/PooledClass.js
  renamed:    src/renderers/shared/stack/__tests__/PooledClass-test.js -> src/renderers/native/__tests__/PooledClass-test.js


  # dead stack code (was never used by Fiber, only added to shared/ as initial example by Seb)
  deleted:    src/renderers/shared/shared/shouldUpdateReactComponent.js


  # dead stack code
  deleted:    src/renderers/shared/stack/reconciler/CallbackQueue.js
  deleted:    src/renderers/shared/stack/reconciler/KeyEscapeUtils.js
  deleted:    src/renderers/shared/stack/reconciler/ReactChildReconciler.js
  deleted:    src/renderers/shared/stack/reconciler/ReactComponentEnvironment.js
  deleted:    src/renderers/shared/stack/reconciler/ReactCompositeComponent.js
  deleted:    src/renderers/shared/stack/reconciler/ReactCompositeComponentTypes.js
  deleted:    src/renderers/shared/stack/reconciler/ReactDebugCurrentStack.js
  deleted:    src/renderers/shared/stack/reconciler/ReactDefaultBatchingStrategy.js
  deleted:    src/renderers/shared/stack/reconciler/ReactEmptyComponent.js
  deleted:    src/renderers/shared/stack/reconciler/ReactHostComponent.js
  deleted:    src/renderers/shared/stack/reconciler/ReactMultiChild.js
  deleted:    src/renderers/shared/stack/reconciler/ReactMultiChildUpdateTypes.js
  deleted:    src/renderers/shared/stack/reconciler/ReactNodeTypes.js
  deleted:    src/renderers/shared/stack/reconciler/ReactOwner.js
  deleted:    src/renderers/shared/stack/reconciler/ReactReconciler.js
  deleted:    src/renderers/shared/stack/reconciler/ReactRef.js
  deleted:    src/renderers/shared/stack/reconciler/ReactSimpleEmptyComponent.js
  deleted:    src/renderers/shared/stack/reconciler/ReactUpdateQueue.js
  deleted:    src/renderers/shared/stack/reconciler/ReactUpdates.js
  deleted:    src/renderers/shared/stack/reconciler/Transaction.js
  deleted:    src/renderers/shared/stack/reconciler/__tests__/Transaction-test.js
  deleted:    src/renderers/shared/stack/reconciler/flattenStackChildren.js
  deleted:    src/renderers/shared/stack/reconciler/getHostComponentFromComposite.js
  deleted:    src/renderers/shared/stack/reconciler/instantiateReactComponent.js
  deleted:    src/renderers/shared/stack/reconciler/traverseStackChildren.js


  # keeping a legacy Flow type so we don't have to touch Fiber files yet
  renamed:    src/renderers/shared/stack/reconciler/ReactInstanceType.js -> src/shared/ReactInstanceType.js

This is just a first step, but the nice thing about it is it doesn’t touch any Fiber code so it can be done at any time. The next step is in #10796.

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I checked it out locally and the build passes too.

@gaearon gaearon merged commit aad0970 into facebook:master Sep 27, 2017
@gaearon gaearon deleted the remove-stack-again branch September 27, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants