Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary event whitelist in production #10802

Merged
merged 3 commits into from
Sep 27, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 24, 2017

Shaves off 150 bytes post gzip. Seems like there’s no need to run this validation in production?

Copy link
Contributor

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just find a way to crush all of these.

@gaearon
Copy link
Collaborator Author

gaearon commented Sep 24, 2017

After ES modules we can turn them into numeric constants that should be free. (?)

@gaearon gaearon merged commit c0a87b2 into facebook:master Sep 27, 2017
gaearon added a commit that referenced this pull request Sep 28, 2017
Fixes a size regression I introduced in #10802.
@gaearon gaearon deleted the remove-unnecessary-prod-whitelist branch September 28, 2017 23:47
gaearon added a commit that referenced this pull request Sep 29, 2017
Fixes a size regression I introduced in #10802.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants