Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
So i'm not sure that the unit tests will catch this ( @nhunzaker might know) effectively give that it's a browser specific warning? I think we should move the original unit test in #7333 to a DOM fixture and ensure that it works. I think we also need understand why this was fixed inadvertantly in v16 before merging
I tested https://jsfiddle.net/97gr5e65/1/ made by @aweary.
After some debugging, I found an interesting point.
Let me explain it with the test case I added.
promising state after update:
step1, update radio1:
step2-1, update radio2's name:
I think if we update checked first, it would be ok
This checks out!
@landvibe Great work spotting this! Do you mind if I push this fixture to your PR?
Still, we need to figure out why
Alternatively, could we just call
Sorry for the delay. I had to spend some time figuring out what
This looks good, I'd just like for the conditions for applying
Thank you for sending this out. I apologize it took this long. This is a fantastic find!