Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint untracked files with yarn linc #11665

Merged
merged 3 commits into from Nov 27, 2017

Conversation

accordeiro
Copy link
Contributor

This PR refers to #11646

Untracked git files will also be linted by yarn linc, except for those ignored by .gitignore.

@gaearon
Copy link
Collaborator

gaearon commented Nov 26, 2017

Can we also do the same for the prettier command?

@accordeiro
Copy link
Contributor Author

Done!

The logic for detecting what files should be linted / formatted is duplicated across prettier and linc. I'm not sure what the policy for reusing code between build files is, but do you think we should consolidate this logic in some sort of changedFiles.js inside scripts/shared?

@gaearon
Copy link
Collaborator

gaearon commented Nov 26, 2017

Can/should we unify the common code into a shared utility?

@gaearon
Copy link
Collaborator

gaearon commented Nov 26, 2017

Oh I guess you asked the same thing. Yes I think so. Wanna give it a try?

@accordeiro
Copy link
Contributor Author

Yep! I've just pushed an update that unifies the common code into scripts/shared/listChangedFiles.js – what do you think?

@gaearon gaearon merged commit 158f040 into facebook:master Nov 27, 2017
@gaearon
Copy link
Collaborator

gaearon commented Nov 27, 2017

This works great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants