Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Presto check (#11886) #11921

Merged
merged 3 commits into from
Jan 4, 2018
Merged

Remove Presto check (#11886) #11921

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c280f65
Merge pull request #1 from facebook/master
skiritsis Nov 26, 2017
3f08d5b
Merge pull request #2 from facebook/master
skiritsis Dec 26, 2017
df95bfb
Removed Presto check
skiritsis Dec 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 1 addition & 18 deletions packages/react-dom/src/events/BeforeInputEventPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ if (ExecutionEnvironment.canUseDOM && 'documentMode' in document) {
// directly represent `beforeInput`. The IE `textinput` event is not as
// useful, so we don't use it.
const canUseTextInputEvent =
ExecutionEnvironment.canUseDOM &&
'TextEvent' in window &&
!documentMode &&
!isPresto();
ExecutionEnvironment.canUseDOM && 'TextEvent' in window && !documentMode;

// In IE9+, we have access to composition events, but the data supplied
// by the native compositionend event may be incorrect. Japanese ideographic
Expand All @@ -42,20 +39,6 @@ const useFallbackCompositionData =
(!canUseCompositionEvent ||
(documentMode && documentMode > 8 && documentMode <= 11));

/**
* Opera <= 12 includes TextEvent in window, but does not fire
* text input events. Rely on keypress instead.
*/
function isPresto() {
const opera = window.opera;
return (
opera !== null &&
typeof opera === 'object' &&
typeof opera.version === 'function' &&
parseInt(opera.version(), 10) <= 12
);
}

const SPACEBAR_CODE = 32;
const SPACEBAR_CHAR = String.fromCharCode(SPACEBAR_CODE);

Expand Down