New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-standard allowing variants of ReactDOMServer render methods (fixes #10064) #12568
Add non-standard allowing variants of ReactDOMServer render methods (fixes #10064) #12568
Conversation
this shouldn't throw warnings, otherwise this won't work with React normally even if this test passes; see facebook/react#12568
This is a big API addition and we ask that those go through the RFC process: https://github.com/reactjs/rfcs |
Any progress on this PR? |
@L42y we'll need to create an RFC before proceeding on this PR. If you, or anyone else for that matter, can help create the RFC, I would be very grateful 👍 |
Is this a reference to the amp-bind bracketed attribute syntax? There is now an XML-compatible syntax, so you can do |
@westonruter Am I mistaken or is this still not documented anywhere? Because I tried it out and it appears to work to me which is very handy. |
@THoisington You're right. I don't think docs have been made for this yet. I've opened a PR: ampproject/amphtml#19835 |
this shouldn't throw warnings, otherwise this won't work with React normally even if this test passes; see facebook/react#12568
Adds 4 new methods to ReactDOMServer:
renderToStringNonStandard
renderToStaticMarkupNonStandard
renderToNodeStreamNonStandard
renderToStaticNodeStreamNonStandard
Each mirrors the existing:
renderToString
renderToStaticMarkup
renderToNodeStream
renderToStaticNodeStream
This allows for rendering markup that may not adhere to W3C standards, yet still works in browsers (like AMP html).