Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal property to fix React DevTools #12727

Merged
merged 1 commit into from
May 1, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented May 1, 2018

It's broken on master because of this:

https://github.com/facebook/react-devtools/blob/f0cde12e3531aae203f8a685f5e74ead58019b0a/backend/attachRendererFiber.js#L239-L241

Longer term we should check the backend into this monorepo.

@pull-bot
Copy link

pull-bot commented May 1, 2018

ReactDOM: size: -0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: e0ca51a...ee404f2

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% +0.1% 611.52 KB 611.8 KB 141.29 KB 141.4 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 100.06 KB 100.06 KB 31.84 KB 31.84 KB UMD_PROD
react-dom.development.js 0.0% +0.1% 595.9 KB 596.18 KB 137.12 KB 137.23 KB NODE_DEV
react-dom.production.min.js -0.0% 0.0% 98.5 KB 98.5 KB 31.06 KB 31.07 KB NODE_PROD
ReactDOM-dev.js 0.0% +0.1% 620.33 KB 620.62 KB 139.88 KB 139.99 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% 0.0% 284.19 KB 284.19 KB 51.94 KB 51.94 KB FB_WWW_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 414.43 KB 414.71 KB 90.2 KB 90.31 KB UMD_DEV
react-art.production.min.js -0.0% 0.0% 90.38 KB 90.38 KB 27.49 KB 27.49 KB UMD_PROD
react-art.development.js +0.1% +0.2% 340.27 KB 340.55 KB 71.52 KB 71.63 KB NODE_DEV
react-art.production.min.js -0.0% 🔺+0.1% 54.91 KB 54.9 KB 16.76 KB 16.77 KB NODE_PROD
ReactART-dev.js +0.1% +0.2% 348.52 KB 348.81 KB 71.1 KB 71.21 KB FB_WWW_DEV
ReactART-prod.js -0.0% 0.0% 166.93 KB 166.92 KB 27.43 KB 27.43 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.2% 348.34 KB 348.62 KB 73.25 KB 73.37 KB UMD_DEV
react-test-renderer.production.min.js -0.0% -0.1% 54.89 KB 54.89 KB 16.72 KB 16.72 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.2% 339.17 KB 339.45 KB 70.54 KB 70.66 KB NODE_DEV
react-test-renderer.production.min.js -0.0% 🔺+0.1% 54.13 KB 54.12 KB 16.29 KB 16.3 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.2% 347.7 KB 347.98 KB 70.18 KB 70.31 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% +0.2% 319.52 KB 319.8 KB 65.99 KB 66.12 KB NODE_DEV
react-reconciler.production.min.js -0.0% 🔺+0.1% 47 KB 47 KB 14.22 KB 14.23 KB NODE_PROD
react-reconciler-persistent.development.js +0.1% +0.2% 318.86 KB 319.14 KB 65.76 KB 65.88 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.0% 0.0% 45.97 KB 45.97 KB 14.09 KB 14.09 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% +0.1% 459.32 KB 459.6 KB 98.22 KB 98.34 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.0% 0.0% 217.88 KB 217.88 KB 36.39 KB 36.4 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.1% +0.1% 459.07 KB 459.35 KB 98.16 KB 98.28 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.0% 0.0% 217.1 KB 217.09 KB 36.26 KB 36.27 KB RN_OSS_PROD
ReactFabric-dev.js +0.1% +0.1% 441.73 KB 442.01 KB 93.82 KB 93.94 KB RN_FB_DEV
ReactFabric-prod.js -0.0% 0.0% 202.77 KB 202.77 KB 33.67 KB 33.67 KB RN_FB_PROD
ReactFabric-dev.js +0.1% +0.1% 441.76 KB 442.05 KB 93.83 KB 93.95 KB RN_OSS_DEV
ReactFabric-prod.js -0.0% 0.0% 202.81 KB 202.81 KB 33.69 KB 33.69 KB RN_OSS_PROD

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants