-
Notifications
You must be signed in to change notification settings - Fork 45.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Java version of Google Closure Compiler #12800
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b8e7368
makes closure compiler threaded
trueadm e5e4ba2
Dans PR with a closure compiler java version
trueadm 926dd88
Remove unused dep
gaearon 4b82b58
Pin GCC
gaearon ac67f46
Prettier
gaearon 7b014d9
Nit rename
gaearon 5c75521
Fix error handling
gaearon 8478f2d
Name plugins consistently
gaearon 3b9f911
Fix lint
gaearon 3d0e4d7
Maybe this works?
gaearon 2a5e40a
or this
gaearon dd90525
AppVeyor
gaearon 06bef07
Fix lint
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| 'use strict'; | ||
|
|
||
| const ClosureCompiler = require('google-closure-compiler').compiler; | ||
| const {promisify} = require('util'); | ||
| const fs = require('fs'); | ||
| const tmp = require('tmp'); | ||
| const writeFileAsync = promisify(fs.writeFile); | ||
|
|
||
| function compile(flags) { | ||
| return new Promise((resolve, reject) => { | ||
| const closureCompiler = new ClosureCompiler(flags); | ||
| closureCompiler.run(function(exitCode, stdOut, stdErr) { | ||
| if (!stdErr) { | ||
| resolve(stdOut); | ||
| } else { | ||
| reject(new Error(stdErr)); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| module.exports = function closure(flags = {}) { | ||
| return { | ||
| name: 'scripts/rollup/plugins/closure-plugin', | ||
| async transformBundle(code) { | ||
| const inputFile = tmp.fileSync(); | ||
| const tempPath = inputFile.name; | ||
| flags = Object.assign({}, flags, {js: tempPath}); | ||
| await writeFileAsync(tempPath, code, 'utf8'); | ||
| const compiledCode = await compile(flags); | ||
| inputFile.removeCallback(); | ||
| return {code: compiledCode}; | ||
| }, | ||
| }; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add an
elsehere with something (e.g. "Unknown error")?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already print the error message itself earlier so these are additive.