-
Notifications
You must be signed in to change notification settings - Fork 45.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary branching from updateContextProvider #13282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code had gotten unnecessarily complex after some recent changes. Cleaned it up a bit.
3a83139
to
e603c64
Compare
ReactDOM: size: -0.3%, gzip: -0.1% Details of bundled changes.Comparing: 840cb1a...e603c64 react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
Generated by 🚫 dangerJS |
sebmarkbage
approved these changes
Jul 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#seemsfinedidnotread
Whoa. How can I get one of these "didnotread" Sebastian stamps 😆 |
Ok great, so if this causes a sev, Seb and I will share equal blame. |
segoddnja
pushed a commit
to segoddnja/react
that referenced
this pull request
Aug 1, 2018
This code had gotten unnecessarily complex after some recent changes. Cleaned it up a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code had gotten unnecessarily complex after some recent changes. Cleaned it up a bit, should save an eensy bit on file size.