Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary branching from updateContextProvider #13282

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jul 27, 2018

This code had gotten unnecessarily complex after some recent changes. Cleaned it up a bit, should save an eensy bit on file size.

This code had gotten unnecessarily complex after some recent changes.
Cleaned it up a bit.
@pull-bot
Copy link

ReactDOM: size: -0.3%, gzip: -0.1%

Details of bundled changes.

Comparing: 840cb1a...e603c64

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.0% 641.37 KB 640.7 KB 150.39 KB 150.38 KB UMD_DEV
react-dom.production.min.js -0.3% -0.1% 96.11 KB 95.87 KB 31.09 KB 31.08 KB UMD_PROD
react-dom.development.js -0.1% -0.0% 637.51 KB 636.84 KB 149.21 KB 149.2 KB NODE_DEV
react-dom.production.min.js -0.3% -0.1% 96.1 KB 95.85 KB 30.61 KB 30.58 KB NODE_PROD
ReactDOM-dev.js -0.1% -0.0% 644.84 KB 644 KB 147.59 KB 147.54 KB FB_WWW_DEV
ReactDOM-prod.js -0.4% -0.1% 278.6 KB 277.59 KB 52.13 KB 52.08 KB FB_WWW_PROD
react-dom.profiling.min.js -0.2% -0.1% 97.23 KB 96.99 KB 31.02 KB 30.99 KB NODE_PROFILING
ReactDOM-profiling.js -0.4% -0.1% 281.9 KB 280.88 KB 52.84 KB 52.8 KB FB_WWW_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.2% -0.1% 427.78 KB 427.11 KB 96.57 KB 96.47 KB UMD_DEV
react-art.production.min.js -0.3% -0.1% 83.49 KB 83.25 KB 25.78 KB 25.75 KB UMD_PROD
react-art.development.js -0.2% -0.1% 360.3 KB 359.63 KB 79.49 KB 79.41 KB NODE_DEV
react-art.production.min.js -0.5% -0.1% 48.47 KB 48.23 KB 15.17 KB 15.15 KB NODE_PROD
ReactART-dev.js -0.2% -0.2% 350.55 KB 349.71 KB 74.38 KB 74.25 KB FB_WWW_DEV
ReactART-prod.js -0.7% -0.1% 149.95 KB 148.93 KB 25.46 KB 25.42 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.2% -0.1% 363.52 KB 362.85 KB 79.77 KB 79.68 KB UMD_DEV
react-test-renderer.production.min.js -0.5% -0.5% 49 KB 48.76 KB 15.12 KB 15.05 KB UMD_PROD
react-test-renderer.development.js -0.2% -0.1% 359.65 KB 358.98 KB 78.8 KB 78.7 KB NODE_DEV
react-test-renderer.production.min.js -0.5% -0.3% 48.71 KB 48.47 KB 14.95 KB 14.9 KB NODE_PROD
ReactTestRenderer-dev.js -0.2% -0.2% 364.81 KB 363.98 KB 77.76 KB 77.63 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.2% -0.1% 348.64 KB 347.97 KB 75.4 KB 75.3 KB NODE_DEV
react-reconciler.production.min.js -0.5% -0.2% 47.69 KB 47.44 KB 14.4 KB 14.37 KB NODE_PROD
react-reconciler-persistent.development.js -0.2% -0.1% 347.26 KB 346.59 KB 74.84 KB 74.75 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.5% -0.2% 47.71 KB 47.45 KB 14.4 KB 14.37 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.2% -0.1% 482.98 KB 482.14 KB 106.64 KB 106.48 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.5% -0.1% 214.77 KB 213.76 KB 37.48 KB 37.44 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.2% -0.1% 482.71 KB 481.88 KB 106.58 KB 106.43 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.5% -0.1% 204.82 KB 203.8 KB 35.86 KB 35.82 KB RN_OSS_PROD
ReactFabric-dev.js -0.2% -0.1% 473.19 KB 472.36 KB 104.2 KB 104.05 KB RN_FB_DEV
ReactFabric-prod.js -0.5% -0.1% 195.93 KB 194.92 KB 34.3 KB 34.27 KB RN_FB_PROD
ReactFabric-dev.js -0.2% -0.1% 473.23 KB 472.39 KB 104.22 KB 104.07 KB RN_OSS_DEV
ReactFabric-prod.js -0.5% -0.1% 195.96 KB 194.95 KB 34.32 KB 34.29 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.5% -0.1% 208.33 KB 207.31 KB 36.56 KB 36.51 KB RN_OSS_PROFILING
ReactFabric-profiling.js -0.5% -0.1% 198.99 KB 197.97 KB 34.95 KB 34.91 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js -0.5% -0.1% 218.24 KB 217.23 KB 38.18 KB 38.13 KB RN_FB_PROFILING
ReactFabric-profiling.js -0.5% -0.1% 198.95 KB 197.93 KB 34.94 KB 34.89 KB RN_FB_PROFILING

Generated by 🚫 dangerJS

Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#seemsfinedidnotread

@bvaughn
Copy link
Contributor

bvaughn commented Jul 27, 2018

Whoa. How can I get one of these "didnotread" Sebastian stamps 😆

@acdlite
Copy link
Collaborator Author

acdlite commented Jul 27, 2018

Ok great, so if this causes a sev, Seb and I will share equal blame.

@acdlite acdlite merged commit 2a2ef7e into facebook:master Jul 27, 2018
@acdlite acdlite deleted the remove-unnecessary-branching branch July 27, 2018 20:42
segoddnja pushed a commit to segoddnja/react that referenced this pull request Aug 1, 2018
This code had gotten unnecessarily complex after some recent changes.
Cleaned it up a bit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants