Deprecate undocumented ReactTestUtils.SimulateNative API #13407
Conversation
Details of bundled changes.Comparing: 69e2a0d...05da6ad react-dom
Generated by |
Huzzah! |
Needs rebase. Probably still want to do this before 17. Although we may want to deprecate even more so maybe that needs to be a part of some other deprecation list. |
Needs rebasing with the latest changes to the event system having landed. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 234905a:
|
I also wonder if we should remove the API entirely when the modern event system flag is enabled? That way I can remove all the internal requirements to use it from the modern event system, saving a bunch of bytes and making the Flow types nicer? I can always do in a follow up too. |
Details of bundled changes.Comparing: 7dfdff4...234905a react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 7dfdff4...234905a react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
e55855e
into
facebook:master
Fixes #11656.
This API is counter-intuitive because it only simulates the React dispatch of a native event, as opposed to simulating what the browser would do on an event. I've seen quite a few people confused by this. It's also completely undocumented.
I think it's a liability to keep this around.