Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Deprecate undocumented ReactTestUtils.SimulateNative API #13407
Merged
Conversation
Details of bundled changes.Comparing: 69e2a0d...05da6ad react-dom
Generated by |
|
Huzzah! |
|
Needs rebase. Probably still want to do this before 17. Although we may want to deprecate even more so maybe that needs to be a part of some other deprecation list. |
|
Needs rebasing with the latest changes to the event system having landed. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 234905a:
|
|
I also wonder if we should remove the API entirely when the modern event system flag is enabled? That way I can remove all the internal requirements to use it from the modern event system, saving a bunch of bytes and making the Flow types nicer? I can always do in a follow up too. |
Details of bundled changes.Comparing: 7dfdff4...234905a react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 7dfdff4...234905a react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
trueadm
merged commit e55855e
into
facebook:master
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #11656.
This API is counter-intuitive because it only simulates the React dispatch of a native event, as opposed to simulating what the browser would do on an event. I've seen quite a few people confused by this. It's also completely undocumented.
I think it's a liability to keep this around.